Add missing static specifiers
Eran Kornblau
eran.kornblau at kaltura.com
Thu Mar 2 13:52:58 UTC 2017
>
> -----Original Message-----
> From: nginx-devel [mailto:nginx-devel-bounces at nginx.org] On Behalf Of Maxim Dounin
> Sent: Thursday, March 2, 2017 3:37 PM
> To: nginx-devel at nginx.org
> Subject: Re: Add missing static specifiers
>
> Hello!
>
> On Thu, Mar 02, 2017 at 07:15:25AM +0000, Eran Kornblau wrote:
>
> [...]
>
> > >
> > Fixed, separated the ints and pointers into two blocks (that made more
> > sense to me than aligning them on a single block)
>
> Doesn't looks like a good solution to me. Rather, I would indent pointer names to the appropriate position, much like it is already done slightly above in the same file:
>
> static ngx_atomic_t connection_counter = 1;
> ngx_atomic_t *ngx_connection_counter = &connection_counter;
>
Fixed
> --
> Maxim Dounin
> http://nginx.org/
> _______________________________________________
> nginx-devel mailing list
> nginx-devel at nginx.org
> http://mailman.nginx.org/mailman/listinfo/nginx-devel
>
Eran
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nginx-add-static4.patch
Type: application/octet-stream
Size: 9850 bytes
Desc: nginx-add-static4.patch
URL: <http://mailman.nginx.org/pipermail/nginx-devel/attachments/20170302/29731107/attachment.obj>
More information about the nginx-devel
mailing list