[nginx] HTTP/2: emit PROTOCOL_ERROR on padding errors.

Valentin Bartenev vbart at nginx.com
Wed Mar 29 12:57:02 UTC 2017


details:   http://hg.nginx.org/nginx/rev/d38161da62cd
branches:  
changeset: 6955:d38161da62cd
user:      Piotr Sikora <piotrsikora at google.com>
date:      Sun Mar 26 01:25:05 2017 -0700
description:
HTTP/2: emit PROTOCOL_ERROR on padding errors.

Signed-off-by: Piotr Sikora <piotrsikora at google.com>

diffstat:

 src/http/v2/ngx_http_v2.c |  6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diffs (23 lines):

diff -r 052305810ca4 -r d38161da62cd src/http/v2/ngx_http_v2.c
--- a/src/http/v2/ngx_http_v2.c	Sun Mar 26 01:25:04 2017 -0700
+++ b/src/http/v2/ngx_http_v2.c	Sun Mar 26 01:25:05 2017 -0700
@@ -812,7 +812,8 @@ ngx_http_v2_state_data(ngx_http_v2_conne
                           "with incorrect length: %uz, padding: %uz",
                           size, h2c->state.padding);
 
-            return ngx_http_v2_connection_error(h2c, NGX_HTTP_V2_SIZE_ERROR);
+            return ngx_http_v2_connection_error(h2c,
+                                                NGX_HTTP_V2_PROTOCOL_ERROR);
         }
 
         h2c->state.length -= 1 + h2c->state.padding;
@@ -1055,7 +1056,8 @@ ngx_http_v2_state_headers(ngx_http_v2_co
                           "with incorrect length: %uz, padding: %uz",
                           h2c->state.length, h2c->state.padding);
 
-            return ngx_http_v2_connection_error(h2c, NGX_HTTP_V2_SIZE_ERROR);
+            return ngx_http_v2_connection_error(h2c,
+                                                NGX_HTTP_V2_PROTOCOL_ERROR);
         }
 
         h2c->state.length -= h2c->state.padding;


More information about the nginx-devel mailing list