[PATCH] Add missing mimetypes for ISO/IEC 26300 / OASIS OpenDocument Format,

[Maxim Dounin]

Hello!

On Sun, Sep 03, 2017 at 10:35:37PM +0200, Michiel Leenaars wrote:

> # HG changeset patch
> # User Michiel Leenaars <ml.software at leenaa.rs>
> # Date 1504470448 -7200
> #      Sun Sep 03 22:27:28 2017 +0200
> # Node ID c3048254f47f935210810ce7be283853f5b2a58d
> # Parent  c7d4017c8876af6d8570e400320537d7d39e9578
> Add missing mimetypes for ISO/IEC 26300 / OASIS OpenDocument Format,
> and for older StarOffice files.

Please also take a look at 
http://nginx.org/en/docs/contributing_changes.html, there should 
be a single-line summary as the first line of the commit log.

> 
> These are required to serve OpenDocument Format files with the correct
> mimetypes. The mimetypes are properly registered at IANA:
> 
> https://www.iana.org/assignments/media-types/media-types.xhtml
> 
> diff -r c7d4017c8876 -r c3048254f47f conf/mime.types
> --- a/conf/mime.types	Tue Aug 22 21:22:59 2017 +0300
> +++ b/conf/mime.types	Sun Sep 03 22:27:28 2017 +0200
> @@ -68,6 +68,38 @@
>      application/vnd.openxmlformats-officedocument.spreadsheetml.sheet          xlsx;
>      application/vnd.openxmlformats-officedocument.presentationml.presentation  pptx;
>  
> +    application/vnd.stardivision.chart                                          sds;
> +    application/vnd.stardivision.calc                                           sdc;
> +    application/vnd.stardivision.writer                                         sdw;
> +    application/vnd.stardivision.writer-global                                  sgl;
> +    application/vnd.stardivision.draw                                           sda;
> +    application/vnd.stardivision.impress                                        sdd;
> +    application/vnd.stardivision.math                                           sdf;
> +    application/vnd.sun.xml.writer                                              sxw;
> +    application/vnd.sun.xml.writer.template                                     stw;
> +    application/vnd.sun.xml.writer.global                                       sxg;
> +    application/vnd.sun.xml.calc                                                sxc;
> +    application/vnd.sun.xml.calc.template                                       stc;
> +    application/vnd.sun.xml.impress                                             sxi;
> +    application/vnd.sun.xml.impress.template                                    sti;
> +    application/vnd.sun.xml.draw                                                sxd;
> +    application/vnd.sun.xml.draw.template                                       std;
> +    application/vnd.sun.xml.math                                                sxm;
> +    application/vnd.oasis.opendocument.text                                     odt;
> +    application/vnd.oasis.opendocument.text-template                            ott;
> +    application/vnd.oasis.opendocument.text-web                                 oth;
> +    application/vnd.oasis.opendocument.text-master                              odm;
> +    application/vnd.oasis.opendocument.graphics                                 odg;
> +    application/vnd.oasis.opendocument.graphics-template                        otg;
> +    application/vnd.oasis.opendocument.presentation                             odp;
> +    application/vnd.oasis.opendocument.presentation-template                    otp;
> +    application/vnd.oasis.opendocument.spreadsheet                              ods;
> +    application/vnd.oasis.opendocument.spreadsheet-template                     ots;
> +    application/vnd.oasis.opendocument.chart                                    odc;
> +    application/vnd.oasis.opendocument.formula                                  odf;
> +    application/vnd.oasis.opendocument.database                                 odb;
> +    application/vnd.oasis.opendocument.image                                    odi;
> +
>      audio/midi                            mid midi kar;
>      audio/mpeg                            mp3;
>      audio/ogg                             ogg;

No, thanks.

We generally do not try to include into conf/mime.types all the 
MIME types in the world, but rather only most popular types 
commonly used on websites.  In particular, this

- prevents serving incorrect MIME type for files accidentally 
  having the same extension as one of the types listed;

- saves some CPU cycles.

If you think that some of these types are popular enough and 
deserve adding nevertheless, please resend the patch reduced to 
only these types (and, ideally, providing some motivation).

> @@ -86,4 +118,6 @@
>      video/x-ms-asf                        asx asf;
>      video/x-ms-wmv                        wmv;
>      video/x-msvideo                       avi;
> +
> +
>  }

Please avoid unrelated whitespace changes.

-- 
Maxim Dounin
http://nginx.org/