[PATCH] Clarify proxy modules $proxy_host variable content

Jack Henschel jackdev at mailbox.org
Tue Dec 18 09:21:31 UTC 2018


Good Morning,

On 12/10/18 6:38 PM, Maxim Dounin wrote:
> Hello!
> 
> On Tue, Dec 04, 2018 at 05:00:10PM +0100, Jack Henschel wrote:
> 
>> From the current documentation it was not immediately obvious (at least
>> to me and my colleague) that nginx does not set the $proxy_host variable
>> to the hosts specified in an upstream block, but literally uses the name
>> used in the proxy_pass directive.
>>
>> Maxim Dounin has explained to me the reason for this [1], nevertheless I
>> think it is worthwhile explicitly adding this behavior to the documentation.
> 
> Thank you for your patch.  It looks too explicit for me though.
> 

That's the point though: to be _explicit_ about this behavior.
I have talked to a few of my colleagues and none of them regarded it as
obvious.

Greetings
Jack


More information about the nginx-devel mailing list