[PATCH] HTTP/2: copy additional headers in the pushed requests

[Maxim Dounin]

Hello!

On Thu, Feb 08, 2018 at 05:07:49PM +0000, Alessandro Ghedini wrote:

> On Thu, Feb 08, 2018 at 05:04:58PM +0000, Alessandro Ghedini wrote:
> > # HG changeset patch
> > # User Alessandro Ghedini <alessandro at cloudflare.com>
> > # Date 1518109032 0
> > #      Thu Feb 08 16:57:12 2018 +0000
> > # Branch push-copy-headers
> > # Node ID 4f7f42e6d13add2ab0c7a9654472bb74085181d1
> > # Parent  a49af443656f2b65ca5de9d8cad5594f44e18ff7
> > HTTP/2: copy additional headers in the pushed requests.
> > 
> > To ensure pushed requests are processed consistently with the original
> > client request, some headers need to be copied from the original request
> > into the pushed one.
> > 
> > The headers currently copied are User-Agent, Accept, Accept-Language and
> > Accept-Encoding.
> 
> So, I'm not quite sure if this is the correct way to go about doing this, but
> I think the issue is real and worth fixing, so I'd be happy to implement this
> differently if you have alternative ideas.

Could you please elaborate more on "the issue is real"?

AFAIR, use of content negotiation with HTTP/2 push isn't a good 
idea[1], and trying to copy some headers might only make things 
more complicated and harder to debug.

[1] https://lists.w3.org/Archives/Public/public-webapps-github/2017Sep/1492.html

-- 
Maxim Dounin
http://mdounin.ru/