[PATCH] HTTP/2: added support for setting custom push request headers

Alessandro Ghedini alessandro at ghedini.me
Mon Feb 12 15:17:32 UTC 2018


On Mon, Feb 12, 2018 at 05:11:55PM +0300, Ruslan Ermilov wrote:
> On Mon, Feb 12, 2018 at 12:35:13PM +0000, Alessandro Ghedini wrote:
> > # HG changeset patch
> > # User Alessandro Ghedini <alessandro at ghedini.me>
> > # Date 1518438578 0
> > #      Mon Feb 12 12:29:38 2018 +0000
> > # Branch http2-push-header
> > # Node ID 4eb0c9e8da0bc52065578e4ee78df1833617ac35
> > # Parent  a49af443656f2b65ca5de9d8cad5594f44e18ff7
> > HTTP/2: added support for setting custom push request headers.
> > 
> > This implementa the http2_push_header configuration directive that makes
> > it possible to set custom request headers for pushed requests.
> > 
> > Complex values are evaluated in the context of the original request,
> > so it's possible to copy its headers into pushed requests.
> > 
> > Example usage:
> > 
> >     http2_push_header User-Agent $http_user_agent;
> 
> If I'm not mistaken, both the original patch and this one
> do not send the copied headers in the PUSH_PROMISE frame.

They both do actually AFAICT, see the changes in ngx_http_v2_push_resource.
Though they don't use HPACK.

Cheers


More information about the nginx-devel mailing list