[nginx] HTTP/2: improved frame info debugging.

Ruslan Ermilov ru at nginx.com
Mon Mar 19 18:33:16 UTC 2018


details:   http://hg.nginx.org/nginx/rev/190591ab0d76
branches:  
changeset: 7241:190591ab0d76
user:      Ruslan Ermilov <ru at nginx.com>
date:      Mon Mar 19 21:32:15 2018 +0300
description:
HTTP/2: improved frame info debugging.

diffstat:

 src/http/v2/ngx_http_v2.c               |  7 +++++--
 src/http/v2/ngx_http_v2_filter_module.c |  6 +++---
 2 files changed, 8 insertions(+), 5 deletions(-)

diffs (40 lines):

diff -r 413189f03c8d -r 190591ab0d76 src/http/v2/ngx_http_v2.c
--- a/src/http/v2/ngx_http_v2.c	Mon Mar 19 16:42:56 2018 +0300
+++ b/src/http/v2/ngx_http_v2.c	Mon Mar 19 21:32:15 2018 +0300
@@ -1990,6 +1990,9 @@ ngx_http_v2_state_settings(ngx_http_v2_c
         return ngx_http_v2_connection_error(h2c, NGX_HTTP_V2_SIZE_ERROR);
     }
 
+    ngx_log_debug0(NGX_LOG_DEBUG_HTTP, h2c->connection->log, 0,
+                   "http2 SETTINGS frame");
+
     return ngx_http_v2_state_settings_params(h2c, pos, end);
 }
 
@@ -2130,8 +2133,8 @@ ngx_http_v2_state_ping(ngx_http_v2_conne
         return ngx_http_v2_state_save(h2c, pos, end, ngx_http_v2_state_ping);
     }
 
-    ngx_log_debug1(NGX_LOG_DEBUG_HTTP, h2c->connection->log, 0,
-                   "http2 PING frame, flags: %ud", h2c->state.flags);
+    ngx_log_debug0(NGX_LOG_DEBUG_HTTP, h2c->connection->log, 0,
+                   "http2 PING frame");
 
     if (h2c->state.flags & NGX_HTTP_V2_ACK_FLAG) {
         return ngx_http_v2_state_skip(h2c, pos, end);
diff -r 413189f03c8d -r 190591ab0d76 src/http/v2/ngx_http_v2_filter_module.c
--- a/src/http/v2/ngx_http_v2_filter_module.c	Mon Mar 19 16:42:56 2018 +0300
+++ b/src/http/v2/ngx_http_v2_filter_module.c	Mon Mar 19 21:32:15 2018 +0300
@@ -1169,9 +1169,9 @@ ngx_http_v2_create_headers_frame(ngx_htt
         cl->next = NULL;
         frame->last = cl;
 
-        ngx_log_debug3(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
-                       "http2:%ui create HEADERS frame %p: len:%uz",
-                       stream->node->id, frame, frame->length);
+        ngx_log_debug4(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
+                       "http2:%ui create HEADERS frame %p: len:%uz fin:%ui",
+                       stream->node->id, frame, frame->length, fin);
 
         return frame;
     }


More information about the nginx-devel mailing list