[njs] Fixed copying of a garbage value.

Dmitry Volyntsev xeioex at nginx.com
Fri Mar 23 10:53:51 UTC 2018


details:   http://hg.nginx.org/njs/rev/77e675beae48
branches:  
changeset: 468:77e675beae48
user:      Dmitry Volyntsev <xeioex at nginx.com>
date:      Fri Mar 23 13:53:27 2018 +0300
description:
Fixed copying of a garbage value.

Found by Clang Static Analyzer.

Additionally, unnecessary body_arg.length zeroing is removed.

diffstat:

 nginx/ngx_http_js_module.c |  2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diffs (12 lines):

diff -r f58d5003ba33 -r 77e675beae48 nginx/ngx_http_js_module.c
--- a/nginx/ngx_http_js_module.c	Thu Mar 22 15:05:08 2018 +0300
+++ b/nginx/ngx_http_js_module.c	Fri Mar 23 13:53:27 2018 +0300
@@ -1503,7 +1503,7 @@ ngx_http_js_ext_subrequest(njs_vm_t *vm,
 
     method = 0;
     args_arg.length = 0;
-    body_arg.length = 0;
+    args_arg.start = NULL;
     has_body = 0;
 
     if (nargs > 2 && !njs_value_is_function(njs_argument(args, 2))) {


More information about the nginx-devel mailing list