[PATCH] HTTP Special Page backgrounds

Maxim Dounin mdounin at mdounin.ru
Sat Sep 22 06:00:52 UTC 2018


Hello!

On Wed, Sep 19, 2018 at 10:41:23AM -0500, Nova wrote:

> TZAG,
> 
> I've run into a compatability issue between Nginx error/special response 
> pages and customized font color and background color in
> user stylesheets. I use white on black as my default color scheme, and 
> since the Nginx special pages specify bgcolor but not color
> (font color), this leads to a "blank" white page (with a hr on it). The 
> attached patch presented for review removes Nginx bgcolor
> on special pages, since this is not necessary to render them as intended 
> without interfering with accessibility settings.
> 
> Best,
> 
> Nova

> # HG changeset patch
> # User Nova DasSarma <nova at novalinium.com>
> # Date 1537367207 18000
> #      Wed Sep 19 09:26:47 2018 -0500
> # Node ID f359ea07f1d61c284fb54706c881120c3e4628c0
> # Parent  87d2ea860f380dc8418c97c0163412f53c2d008e
> HTTP Special Responses: removed bgcolor attribute on body.
> 
> bgcolor overrides compatibility settings in browsers and leads to undesirable behavior when the default font color is set to white in the browser, since font-color is not also overridden.

[...]

Thanks for the patch.

I've extended it on the autoindex module where the same problem 
occurs, and committed it with some minor changes to commit log:

http://hg.nginx.org/nginx/rev/170922952477

-- 
Maxim Dounin
http://mdounin.ru/


More information about the nginx-devel mailing list