Bring SPDY back in nginx-1.14.0

[Dewangga Alam]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Found a solution but need to confirm.

Is it save to change :

DEB_LDFLAGS_MAINT_APPEND=-Wl,--as-needed -pie
to
DEB_LDFLAGS_MAINT_APPEND=-Wl,--allow-multiple-definition -pie

Need advice.

On 29/09/18 11.12, Dewangga Alam wrote:
> Sorry, please ignore my previous patch file. The previous error was
> reproduce-able using this attached patch.
> 
> On 29/09/18 08.29, Dewangga Alam wrote:
>> Hello!
> 
>> This is my first post in nginx-devel mailing list.
> 
>> Currently, I am using nginx-1.8.1 in production. And I need SPDY
>> to works on nginx-1.14.0 co-exists with http/2. Because I still
>> need SPDY for compatibility, and for future deployment, I will
>> migrate it all to HTTP/2.
> 
>> To make this possible, so I was create patch to make SPDY and 
>> HTTP/2 run together.
> 
>> I was read cloudflare patch regarding this issue (spdy & http/2)
>>  and make some adjustment (patch attached).
> 
>> But, got some errors when compiling. The error message was :
> 
>> objs/src/http/ngx_http_spdy.o: In function 
>> `ngx_http_spdy_send_output_queue': 
>> ./debian/build-nginx/src/http/ngx_http_spdy.c:664: multiple 
>> definition of `ngx_http_spdy_send_output_queue' 
>> objs/src/http/ngx_http_spdy.o:./debian/build-nginx/src/http/ngx_http_
s
>
>> 
pd
> 
> 
> 
> y.c:664:
>> first defined here objs/src/http/ngx_http_spdy.o: In function 
>> `ngx_http_spdy_init': 
>> ./debian/build-nginx/src/http/ngx_http_spdy.c:386: multiple 
>> definition of `ngx_http_spdy_init' 
>> objs/src/http/ngx_http_spdy.o:./debian/build-nginx/src/http/ngx_http_
s
>
>> 
pd
> 
> 
> 
> y.c:386:
>> first defined here objs/src/http/ngx_http_spdy.o: In function 
>> `ngx_http_spdy_request_headers_init': 
>> ./debian/build-nginx/src/http/ngx_http_spdy.c:2813: multiple 
>> definition of `ngx_http_spdy_request_headers_init' 
>> objs/src/http/ngx_http_spdy.o:./debian/build-nginx/src/http/ngx_http_
s
>
>> 
pd
> 
> 
> 
> y.c:2813:
>> first defined here objs/src/http/ngx_http_spdy.o: In function 
>> `ngx_http_spdy_read_request_body': 
>> ./debian/build-nginx/src/http/ngx_http_spdy.c:3274: multiple 
>> definition of `ngx_http_spdy_read_request_body' 
>> objs/src/http/ngx_http_spdy.o:./debian/build-nginx/src/http/ngx_http_
s
>
>> 
pd
> 
> 
> 
> y.c:3274:
>> first defined here objs/src/http/ngx_http_spdy.o: In function 
>> `ngx_http_spdy_close_stream': 
>> ./debian/build-nginx/src/http/ngx_http_spdy.c:3362: multiple 
>> definition of `ngx_http_spdy_close_stream' 
>> objs/src/http/ngx_http_spdy.o:./debian/build-nginx/src/http/ngx_http_
s
>
>> 
pd
> 
> 
> 
> y.c:3362:
>> first defined here 
>> objs/src/http/ngx_http_spdy_module.o:(.data.rel.local+0xc0): 
>> multiple definition of `ngx_http_spdy_module' 
>> objs/src/http/ngx_http_spdy_module.o:(.data.rel.local+0xc0):
>> first defined here
> 
>> https://paste.fedoraproject.org/paste/HGW3Q7Pj8oxnD473Xw3Cdw/raw
> 
>> Is there any hints to fix the error?
> 
>> Wr, Dewangga Alam
> 
> 
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEZpxiw/Jg6pEte5xQ5X/SIKAozXAFAluvBjIACgkQ5X/SIKAo
zXAKyw//ZDn7FhL6K1G9f+p9AXGdM1LwOOG1bT96VOcPoT6Lep4dkK4DuCwSNuJV
SjwRX85sEz2JtFCBkTezTxWy2m1UkxCfuyVkChADrzLQYSZxNu3kzqIln1KNwmW0
ztaZincR9zisxp+B6n5E8QMpjQlwGdqT8wlueDyTj901F8idklJlH2TBv3QYbIaq
jlzzmd9Bfqhexj3yl8mlLyn3yskADG4Y8S/EhgnW+rw2+oxa5xzKJdIAm2tPL5lu
Y7j4vFu+1S5+S8SHBiDKKIemnajSwlKOkL6JUZtGQUna+r8alfhDikdN8NDCKIi8
iUAF5FBnKhMxVdGZEO7yTQcmUfAPnEiXyTUN+2h0Buj0SmBKlsnRWCRZW2JcfY6k
cZrJRYLdeK6FCjJLmCzgFmUyzImfVf7Ty/Hmqpq5213GZQEJKj6n8/mvrVOYKSpP
gheDFl03g2hhrM14p5S2u/EPtkRmUyxEYBWwjdo6xJFFIXmM96/V6f5rpIgHMA3p
x5LIkO554vNRLG9jMcok0ciT8uu7c3re0o71Q0frDkyPDqMmNeK4aGzbvkg4YmQo
mx9BDUV7aOA1CW0dgPrCDs+74IP1gk41E5TxhCcbu2FfShI8knz6uh+67Wc2bA1y
absI1FeYEuQZc+VhvVf7F22yfEWLTmTv77BIBPTi6LSDmY03j28=
=fzbI
-----END PGP SIGNATURE-----