[nginx] Perl: removed unneeded NGX_DONE test.

Maxim Dounin mdounin at mdounin.ru
Fri Jul 12 14:53:49 UTC 2019


details:   https://hg.nginx.org/nginx/rev/919a5c6c828c
branches:  
changeset: 7523:919a5c6c828c
user:      Maxim Dounin <mdounin at mdounin.ru>
date:      Thu Jul 11 23:20:08 2019 +0300
description:
Perl: removed unneeded NGX_DONE test.

The NGX_DONE test in ngx_http_perl_handle_request() was introduced
in 1702:86bb52e28ce0, which also modified ngx_http_perl_call_handler()
to return NGX_DONE with c->destroyed.  The latter part was then
removed in 3050:f54b02dbb12b, so NGX_DONE test is no longer needed.

diffstat:

 src/http/modules/perl/ngx_http_perl_module.c |  5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diffs (15 lines):

diff --git a/src/http/modules/perl/ngx_http_perl_module.c b/src/http/modules/perl/ngx_http_perl_module.c
--- a/src/http/modules/perl/ngx_http_perl_module.c
+++ b/src/http/modules/perl/ngx_http_perl_module.c
@@ -228,11 +228,6 @@ ngx_http_perl_handle_request(ngx_http_re
     ngx_log_debug1(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
                    "perl handler done: %i", rc);
 
-    if (rc == NGX_DONE) {
-        ngx_http_finalize_request(r, rc);
-        return;
-    }
-
     if (rc > 600) {
         rc = NGX_OK;
     }


More information about the nginx-devel mailing list