[nginx] Unconditional compilation of the postpone filter.

Roman Arutyunyan arut at nginx.com
Mon May 13 12:34:28 UTC 2019


details:   https://hg.nginx.org/nginx/rev/ee36940cfb0f
branches:  
changeset: 7506:ee36940cfb0f
user:      Roman Arutyunyan <arut at nginx.com>
date:      Wed May 08 19:22:13 2019 +0300
description:
Unconditional compilation of the postpone filter.

Postpone filter is an essential part of subrequest functionality.  In absence
of it a subrequest response body is sent to the client out of order with
respect to the main request header and body, as well as other subrequests.
For in-memory subrequests the response is also sent to the client instead of
being stored in memory.

Currently the postpone filter is automatically enabled if one of the following
standard modules which are known to create subrequests is enabled: ssi, slice,
addition.  However a third-party module that creates subrequests can still be
built without the postpone filter or be dynamically loaded in nginx built
without it.

diffstat:

 auto/modules |  19 ++-----------------
 auto/options |   1 -
 2 files changed, 2 insertions(+), 18 deletions(-)

diffs (52 lines):

diff -r 16a1adadf437 -r ee36940cfb0f auto/modules
--- a/auto/modules	Wed Apr 24 16:38:56 2019 +0300
+++ b/auto/modules	Wed May 08 19:22:13 2019 +0300
@@ -102,21 +102,6 @@ if [ $HTTP = YES ]; then
     fi
 
 
-    if [ $HTTP_SSI = YES ]; then
-        HTTP_POSTPONE=YES
-    fi
-
-
-    if [ $HTTP_SLICE = YES ]; then
-        HTTP_POSTPONE=YES
-    fi
-
-
-    if [ $HTTP_ADDITION = YES ]; then
-        HTTP_POSTPONE=YES
-    fi
-
-
     # the module order is important
     #     ngx_http_static_module
     #     ngx_http_gzip_static_module
@@ -252,13 +237,13 @@ if [ $HTTP = YES ]; then
         . auto/module
     fi
 
-    if [ $HTTP_POSTPONE = YES ]; then
+    if :; then
         ngx_module_name=ngx_http_postpone_filter_module
         ngx_module_incs=
         ngx_module_deps=
         ngx_module_srcs=src/http/ngx_http_postpone_filter_module.c
         ngx_module_libs=
-        ngx_module_link=$HTTP_POSTPONE
+        ngx_module_link=YES
 
         . auto/module
     fi
diff -r 16a1adadf437 -r ee36940cfb0f auto/options
--- a/auto/options	Wed Apr 24 16:38:56 2019 +0300
+++ b/auto/options	Wed May 08 19:22:13 2019 +0300
@@ -60,7 +60,6 @@ HTTP_GZIP=YES
 HTTP_SSL=NO
 HTTP_V2=NO
 HTTP_SSI=YES
-HTTP_POSTPONE=NO
 HTTP_REALIP=NO
 HTTP_XSLT=NO
 HTTP_IMAGE_FILTER=NO


More information about the nginx-devel mailing list