[nginx] Xslt: disabled ranges.

Roman Arutyunyan arut at nginx.com
Thu Jul 23 09:00:17 UTC 2020

details:   https://hg.nginx.org/nginx/rev/1f3bf1734a77
changeset: 7686:1f3bf1734a77
user:      Roman Arutyunyan <arut at nginx.com>
date:      Wed Jul 22 22:16:19 2020 +0300
Xslt: disabled ranges.

Previously, the document generated by the xslt filter was always fully sent
to client even if a range was requested and response status was 206 with
appropriate Content-Range.

The xslt module is unable to serve a range because of suspending the header
filter chain.  By the moment full response xml is buffered by the xslt filter,
range header filter is not called yet, but the range body filter has already
been called and did nothing.

The fix is to disable ranges by resetting the r->allow_ranges flag much like
the image filter that employs a similar technique.


 src/http/modules/ngx_http_xslt_filter_module.c |  1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diffs (11 lines):

diff -r 4f30f75dbdf3 -r 1f3bf1734a77 src/http/modules/ngx_http_xslt_filter_module.c
--- a/src/http/modules/ngx_http_xslt_filter_module.c	Tue Jul 21 20:34:29 2020 +0300
+++ b/src/http/modules/ngx_http_xslt_filter_module.c	Wed Jul 22 22:16:19 2020 +0300
@@ -233,6 +233,7 @@ ngx_http_xslt_header_filter(ngx_http_req
     ngx_http_set_ctx(r, ctx, ngx_http_xslt_filter_module);
     r->main_filter_need_in_memory = 1;
+    r->allow_ranges = 0;
     return NGX_OK;

More information about the nginx-devel mailing list