[PATCH] Add support for dark color scheme in default index.html page
Maxim Dounin
mdounin at mdounin.ru
Mon Aug 16 13:41:24 UTC 2021
Hello!
On Sun, Aug 15, 2021 at 07:47:33PM -0700, Duncan Lock wrote:
> That works for me!
>
> In this case, because the CSS is inline, there's no difference between
> using the meta tag and the CSS color-scheme.
Committed, thanks for testing.
> If you want to stop hard-coding things, I would also take out those
> hard-coded Windows only fonts - and just let the browsers default
> cross-platform styles - and the users preferences, decide the font to
> use.
> So, I would suggest also changing this:
>
> font-family: Tahoma, Verdana, Arial, sans-serif;
>
> to this:
>
> font-family: sans-serif;
>
> Which is simpler and produces better results cross-platform?
Define "better". Tahoma certainly looks better than Arial to me,
and AFAIR that's basically the reason why Valentin used this
font-family instead of just sans-serif back in ed470a7bf7fd
(http://hg.nginx.org/nginx/rev/ed470a7bf7fd). Since this falls
back to sans-serif anyway, I don't see reasons to change things
here.
--
Maxim Dounin
http://mdounin.ru/
More information about the nginx-devel
mailing list