[nginx] Upstream: fixed timeouts with gRPC, SSL and select (ticket #2229).

Maxim Dounin mdounin at mdounin.ru
Fri Aug 20 19:14:06 UTC 2021

details:   https://hg.nginx.org/nginx/rev/058a67435e83
changeset: 7906:058a67435e83
user:      Maxim Dounin <mdounin at mdounin.ru>
date:      Fri Aug 20 03:53:56 2021 +0300
Upstream: fixed timeouts with gRPC, SSL and select (ticket #2229).

With SSL it is possible that an established connection is ready for
reading after the handshake.  Further, events might be already disabled
in case of level-triggered event methods.  If this happens and
ngx_http_upstream_send_request() blocks waiting for some data from
the upstream, such as flow control in case of gRPC, the connection
will time out due to no read events on the upstream connection.

Fix is to explicitly check the c->read->ready flag if sending request
blocks and post a read event if it is set.

Note that while it is possible to modify ngx_ssl_handshake() to keep
read events active, this won't completely resolve the issue, since
there can be data already received during the SSL handshake
(see 573bd30e46b4).


 src/http/ngx_http_upstream.c |  4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diffs (14 lines):

diff -r 13d0c1d26d47 -r 058a67435e83 src/http/ngx_http_upstream.c
--- a/src/http/ngx_http_upstream.c	Fri Aug 13 03:57:47 2021 -0400
+++ b/src/http/ngx_http_upstream.c	Fri Aug 20 03:53:56 2021 +0300
@@ -2113,6 +2113,10 @@ ngx_http_upstream_send_request(ngx_http_
             c->tcp_nopush = NGX_TCP_NOPUSH_UNSET;
+        if (c->read->ready) {
+            ngx_post_event(c->read, &ngx_posted_events);
+        }

More information about the nginx-devel mailing list