[nginx-quic] fastcgi cookie param is overwritten resulting in getting only last cookie

[Guillaume Bilic]

Hi all,



Using nginx-quic (1.21.4), cookies are parsed individually by http3 code :



*2021/12/23 14:29:37 [debug] 32322#0: *3576 http3 parse literal done
"number1=this+is+the+first+one"*

*2021/12/23 14:29:37 [debug] 32322#0: *3576 http3 parse field lri done
static[5] "number1=this+is+the+first+one"*

*2021/12/23 14:29:37 [debug] 32322#0: *3576 http3 static[5] lookup
"cookie":""*

*2021/12/23 14:29:37 [debug] 32322#0: *3576 http3 parse field
representation done*

*2021/12/23 14:29:37 [debug] 32322#0: *3576 http3 header: "cookie:
number1=this+is+the+first+one"*

*2021/12/23 14:29:37 [debug] 32322#0: *3576 http3 parse field
representation*

*2021/12/23 14:29:37 [debug] 32322#0: *3576 http3 parse field lri*

*2021/12/23 14:29:37 [debug] 32322#0: *3576 http3 parse prefix int 5*

*2021/12/23 14:29:37 [debug] 32322#0: *3576 http3 parse prefix int 24*

*2021/12/23 14:29:37 [debug] 32322#0: *3576 http3 parse literal huff:1,
len:24*

*2021/12/23 14:29:37 [debug] 32322#0: *3576 http3 parse literal done
"number2=this+is+the+second+one"*

*2021/12/23 14:29:37 [debug] 32322#0: *3576 http3 parse field lri done
static[5] "number2=this+is+the+second+one"*

*2021/12/23 14:29:37 [debug] 32322#0: *3576 http3 static[5] lookup
"cookie":""*

*2021/12/23 14:29:37 [debug] 32322#0: *3576 http3 parse field
representation done*

*2021/12/23 14:29:37 [debug] 32322#0: *3576 http3 header: "cookie:
number2=this+is+the+second+one"*

*2021/12/23 14:29:37 [debug] 32322#0: *3576 http3 parse field
representation*

*2021/12/23 14:29:37 [debug] 32322#0: *3576 http3 parse field lri*

*2021/12/23 14:29:37 [debug] 32322#0: *3576 http3 parse prefix int 5*

*2021/12/23 14:29:37 [debug] 32322#0: *3576 http3 parse prefix int 23*

*2021/12/23 14:29:37 [debug] 32322#0: *3576 http3 parse literal huff:1,
len:23*

*2021/12/23 14:29:37 [debug] 32322#0: *3576 http3 parse literal done
"number3=this+is+the+third+one"*

*2021/12/23 14:29:37 [debug] 32322#0: *3576 http3 parse field lri done
static[5] "number3=this+is+the+third+one"*

2021/12/23 14:29:37 [debug] 32322#0: *3576 http3 static[5] lookup
"cookie":""

2021/12/23 14:29:37 [debug] 32322#0: *3576 http3 parse field representation
done

2021/12/23 14:29:37 [debug] 32322#0: *3576 http3 parse headers done

2021/12/23 14:29:37 [debug] 32322#0: *3576 http3 header: "cookie:
number3=this+is+the+third+one »





But then the fastcgi param HTTP_COOKIE is passed for each cookie, resulting
in overwriting it and keeping only the last one :



*2021/12/23 14:29:37 [debug] 32322#0: *3576 fastcgi param: "HTTP_COOKIE:
number1=this+is+the+first+one"*

*2021/12/23 14:29:37 [debug] 32322#0: *3576 fastcgi param: "HTTP_COOKIE:
number2=this+is+the+second+one"*

*2021/12/23 14:29:37 [debug] 32322#0: *3576 fastcgi param: "HTTP_COOKIE:
number3=this+is+the+third+one »*



The HTTP_COOKIE param should be the whole cookie header.

Http2 code handles cookie header in a dedicated function
« ngx_http_v2_construct_cookie_header » and then processes other headers.

There doesn’t seem to be the case of http3 code which process cookie the
same way of others headers.



Regards,

Guillaume
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.nginx.org/pipermail/nginx-devel/attachments/20211223/6ecad6e1/attachment-0001.htm>