[PATCH] Define phony make targets as such.

Maxim Dounin mdounin at mdounin.ru
Tue Feb 9 14:15:27 UTC 2021


On Mon, Feb 08, 2021 at 07:56:09PM +0100, Thibault Nélis wrote:

> On Mon, 2021-02-08 at 17:33 +0300, Maxim Konovalov wrote:
> > Ruslan Ermilov is looking at it.  He will come with his comments in
> > next several days.
> All good; feel free to prioritize as low priority internally.
> Ruslan, I just realized I should have used single quotes for the sed
> expression. Technically everything is fine even with the $/ sequence
> because / is not a valid shell variable identifier and is thus not
> substituted (as intended), but anyone reading this (as I did now and as
> I should have before sending) might have an unnecessary think about
> this. Feel free to change the double quotes into single quotes if you
> prefer.

Certainly there is no need to use sed at all.  And using .PHONY as 
the first target is going to break badly on make's without .PHONY 
support, such as nmake on Windows.

Maxim Dounin

More information about the nginx-devel mailing list