[nginx] Mail: fixed SMTP pipelining to send the response immediately.

Maxim Dounin mdounin at mdounin.ru
Wed May 19 01:27:09 UTC 2021

details:   https://hg.nginx.org/nginx/rev/c72d8839f427
changeset: 7835:c72d8839f427
user:      Maxim Dounin <mdounin at mdounin.ru>
date:      Wed May 19 03:13:12 2021 +0300
Mail: fixed SMTP pipelining to send the response immediately.

Previously, if there were some pipelined SMTP data in the buffer when
a proxied connection with the backend was established, nginx called
ngx_mail_proxy_handler() to send these data, and not tried to send the
response to the last command.  In most cases, this response was later sent
along with the response to the pipelined command, but if for some reason
client decides to wait for the response before finishing the next command
this might result in a connection hang.

Fix is to always call ngx_mail_proxy_handler() to send the response, and
additionally post an event to send the pipelined data if needed.


 src/mail/ngx_mail_proxy_module.c |  9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)

diffs (20 lines):

diff -r b3f4d83d6fd0 -r c72d8839f427 src/mail/ngx_mail_proxy_module.c
--- a/src/mail/ngx_mail_proxy_module.c	Sat May 08 20:31:03 2021 +0300
+++ b/src/mail/ngx_mail_proxy_module.c	Wed May 19 03:13:12 2021 +0300
@@ -813,12 +813,11 @@ ngx_mail_proxy_smtp_handler(ngx_event_t 
         c->log->action = NULL;
         ngx_log_error(NGX_LOG_INFO, c->log, 0, "client logged in");
-        if (s->buffer->pos == s->buffer->last) {
-            ngx_mail_proxy_handler(s->connection->write);
+        if (s->buffer->pos < s->buffer->last) {
+            ngx_post_event(c->write, &ngx_posted_events);
+        }
-        } else {
-            ngx_mail_proxy_handler(c->write);
-        }
+        ngx_mail_proxy_handler(s->connection->write);

More information about the nginx-devel mailing list