[PATCH] Upstream: fixed logging level of upstream invalid header errors

[Sergey Kandaurov]

> On 16 Oct 2021, at 01:03, Maxim Dounin <mdounin at mdounin.ru> wrote:
> 
> # HG changeset patch
> # User Maxim Dounin <mdounin at mdounin.ru>
> # Date 1634321061 -10800
> #      Fri Oct 15 21:04:21 2021 +0300
> # Node ID 568299e3799dcd9ec361c998935d267a33b17daf
> # Parent  01829d1620956241455867fd8ba28ba54eed5aa9
> Upstream: fixed logging level of upstream invalid header errors.
> 
> In b87b7092cedb (nginx 1.21.1), logging level of "upstream sent invalid
> header" errors was accidentally changed to "info".  This change restores
> the "error" level, which is a proper logging level for upstream-side
> errors.
> 
> diff --git a/src/http/modules/ngx_http_fastcgi_module.c b/src/http/modules/ngx_http_fastcgi_module.c
> --- a/src/http/modules/ngx_http_fastcgi_module.c
> +++ b/src/http/modules/ngx_http_fastcgi_module.c
> @@ -2021,7 +2021,7 @@ ngx_http_fastcgi_process_header(ngx_http
> 
>             /* rc == NGX_HTTP_PARSE_INVALID_HEADER */
> 
> -            ngx_log_error(NGX_LOG_INFO, r->connection->log, 0,
> +            ngx_log_error(NGX_LOG_ERR, r->connection->log, 0,
>                           "upstream sent invalid header: \"%*s\\x%02xd...\"",
>                           r->header_end - r->header_name_start,
>                           r->header_name_start, *r->header_end);
> diff --git a/src/http/modules/ngx_http_proxy_module.c b/src/http/modules/ngx_http_proxy_module.c
> --- a/src/http/modules/ngx_http_proxy_module.c
> +++ b/src/http/modules/ngx_http_proxy_module.c
> @@ -2021,7 +2021,7 @@ ngx_http_proxy_process_header(ngx_http_r
> 
>         /* rc == NGX_HTTP_PARSE_INVALID_HEADER */
> 
> -        ngx_log_error(NGX_LOG_INFO, r->connection->log, 0,
> +        ngx_log_error(NGX_LOG_ERR, r->connection->log, 0,
>                       "upstream sent invalid header: \"%*s\\x%02xd...\"",
>                       r->header_end - r->header_name_start,
>                       r->header_name_start, *r->header_end);
> diff --git a/src/http/modules/ngx_http_scgi_module.c b/src/http/modules/ngx_http_scgi_module.c
> --- a/src/http/modules/ngx_http_scgi_module.c
> +++ b/src/http/modules/ngx_http_scgi_module.c
> @@ -1142,7 +1142,7 @@ ngx_http_scgi_process_header(ngx_http_re
> 
>         /* rc == NGX_HTTP_PARSE_INVALID_HEADER */
> 
> -        ngx_log_error(NGX_LOG_INFO, r->connection->log, 0,
> +        ngx_log_error(NGX_LOG_ERR, r->connection->log, 0,
>                       "upstream sent invalid header: \"%*s\\x%02xd...\"",
>                       r->header_end - r->header_name_start,
>                       r->header_name_start, *r->header_end);
> diff --git a/src/http/modules/ngx_http_uwsgi_module.c b/src/http/modules/ngx_http_uwsgi_module.c
> --- a/src/http/modules/ngx_http_uwsgi_module.c
> +++ b/src/http/modules/ngx_http_uwsgi_module.c
> @@ -1363,7 +1363,7 @@ ngx_http_uwsgi_process_header(ngx_http_r
> 
>         /* rc == NGX_HTTP_PARSE_INVALID_HEADER */
> 
> -        ngx_log_error(NGX_LOG_INFO, r->connection->log, 0,
> +        ngx_log_error(NGX_LOG_ERR, r->connection->log, 0,
>                       "upstream sent invalid header: \"%*s\\x%02xd...\"",
>                       r->header_end - r->header_name_start,
>                       r->header_name_start, *r->header_end);
> 

Looks good.

-- 
Sergey Kandaurov