[PATCH] proxy_cache_max_range_offset could affect the background updating

[Sangdeuk Kwon]

# HG changeset patch
# User Sangdeuk Kwon <sangdeuk.kwon at quantil.com>
# Date 1670390583 -32400
#      Wed Dec 07 14:23:03 2022 +0900
# Node ID a1069fbf10ffd806b7c8d6deb3f6546edc7b0427
# Parent  0b360747c74e3fa7e439e0684a8cf1da2d14d8f6
proxy_cache_max_range_offset could affect the background updating

proxy_cache_max_range_offset doesn't care about the upstream of background
updating.
So, nginx drops the new cache file after background updating.
This behavior is strange because background updating is just to fetch
new content after serving a stale cache, not to serve it.

I think the background updating should be not affected by
proxy_cache_max_range_offset.

Related directives:
proxy_cache_max_range_offset 10;
proxy_cache_use_stale updating;
proxy_cache_background_update on;

diff -r 0b360747c74e -r a1069fbf10ff src/http/ngx_http_upstream.c
--- a/src/http/ngx_http_upstream.c      Thu Nov 24 23:08:30 2022 +0400
+++ b/src/http/ngx_http_upstream.c      Wed Dec 07 14:23:03 2022 +0900
@@ -986,7 +986,9 @@
         return rc;
     }

-    if (ngx_http_upstream_cache_check_range(r, u) == NGX_DECLINED) {
+    if (!r->background
+        && ngx_http_upstream_cache_check_range(r, u) == NGX_DECLINED)
+    {
         u->cacheable = 0;
     }
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.nginx.org/pipermail/nginx-devel/attachments/20221207/275cf139/attachment.htm>