[PATCH] public upstream connect and finalize request

[Maxim Dounin]

Hello!

On Wed, Jun 15, 2022 at 08:41:57AM +0500, RekGRpth wrote:

> # HG changeset patch
> # User RekGRpth <rekgrpth at gmail.com>
> # Date 1655264350 -18000
> #      Wed Jun 15 08:39:10 2022 +0500
> # Node ID 4ae4c147e3b9280e8aca76e99807bbbbf6059de5
> # Parent  861f076eab72dab85bd5eaa56da770f8b10aa8ad
> public upstream connect and finalize request
> 
> diff -r 861f076eab72 -r 4ae4c147e3b9 src/http/ngx_http_upstream.c
> --- a/src/http/ngx_http_upstream.c	Tue Jun 14 10:39:58 2022 +0400
> +++ b/src/http/ngx_http_upstream.c	Wed Jun 15 08:39:10 2022 +0500
> @@ -35,8 +35,6 @@
>  static void ngx_http_upstream_wr_check_broken_connection(ngx_http_request_t *r);
>  static void ngx_http_upstream_check_broken_connection(ngx_http_request_t *r,
>      ngx_event_t *ev);
> -static void ngx_http_upstream_connect(ngx_http_request_t *r,
> -    ngx_http_upstream_t *u);
>  static ngx_int_t ngx_http_upstream_reinit(ngx_http_request_t *r,
>      ngx_http_upstream_t *u);
>  static void ngx_http_upstream_send_request(ngx_http_request_t *r,
> @@ -96,8 +94,6 @@
>  static void ngx_http_upstream_next(ngx_http_request_t *r,
>      ngx_http_upstream_t *u, ngx_uint_t ft_type);
>  static void ngx_http_upstream_cleanup(void *data);
> -static void ngx_http_upstream_finalize_request(ngx_http_request_t *r,
> -    ngx_http_upstream_t *u, ngx_int_t rc);
>  
>  static ngx_int_t ngx_http_upstream_process_header_line(ngx_http_request_t *r,
>      ngx_table_elt_t *h, ngx_uint_t offset);

[...]

Thanks for the patch.

Quoting the Contributing Changes article 
(http://nginx.org/en/docs/contributing_changes.html):

"Try to make it clear why the suggested change is needed, and 
provide a use case, if possible."

Hope this helps.

-- 
Maxim Dounin
http://mdounin.ru/