[PATCH] QUIC: improved SO_COOKIE configure test

[Maxim Dounin]

Hello!

On Wed, Jan 25, 2023 at 12:22:54AM +0100, Alex Colomar wrote:

> On 1/23/23 03:59, Maxim Dounin wrote:
> > # HG changeset patch
> > # User Maxim Dounin <mdounin at mdounin.ru>
> > # Date 1674441584 -10800
> > #      Mon Jan 23 05:39:44 2023 +0300
> > # Branch quic
> > # Node ID 849f3b4043ee07a65bbfc4ad136e4246002ec00c
> > # Parent  6bb884dc72916dc675df65d02abee0c9cfabc916
> > QUIC: improved SO_COOKIE configure test.
> > 
> > In nginx source code the inttypes.h include, if available, is used to define
> > standard integer types.  Changed the SO_COOKIE configure test to follow this.
> 
> May I ask for curiosity why do you prefer <inttypes.h> for the standard 
> integer types?
> 
> Normally, the preferred header file is <stdint.h>, since it's smaller; 
> unless you use the macros or functions from <inttypes.h>, which are 
> things like PRId32, or imaxabs(3).
> 
> Is there any portability issue with <stdint.h>?

The inttypes.h is more portable: for example, stdint.h is not 
available on FreeBSD before FreeBSD 5.0:

https://github.com/freebsd/freebsd-src/commit/0ac2d551f20a8769869f61ebfe742fd55cef70b9

While this is not important for the particular test (since all 
known Linux versions with SO_COOKIE do have stdint.h), using the 
same header in all tests and the code is good from consistency 
point of view.

-- 
Maxim Dounin
http://mdounin.ru/