[PATCH 1 of 2] Tests: fixed h2_http2.t when nginx compiled without ALPN support

Maxim Dounin mdounin at mdounin.ru
Tue Jul 11 23:42:47 UTC 2023


Hello!

On Mon, Jul 10, 2023 at 08:23:42PM +0400, Sergey Kandaurov wrote:

> > On 1 Jul 2023, at 04:21, Maxim Dounin <mdounin at mdounin.ru> wrote:
> > 
> > # HG changeset patch
> > # User Maxim Dounin <mdounin at mdounin.ru>
> > # Date 1688164311 -10800
> > #      Sat Jul 01 01:31:51 2023 +0300
> > # Node ID bf9961a4507784b669650e7ef1d3cbacce8c94e1
> > # Parent  22f45bf99a9e39e02d8ce07532d2cbfc89e7d8d1
> > Tests: fixed h2_http2.t when nginx compiled without ALPN support.
> > 
> > ALPN support is only available with OpenSSL 1.0.2 or newer.
> > 
> > diff --git a/h2_http2.t b/h2_http2.t
> > --- a/h2_http2.t
> > +++ b/h2_http2.t
> > @@ -127,9 +127,16 @@ ok(!get_ssl_socket(8443, 'disabled'), 's
> > 
> > }
> > 
> > +TODO: {
> > +local $TODO = 'OpenSSL too old'
> > +	if $t->has_module('OpenSSL')
> > +	and not $t->has_feature('openssl:1.0.2');
> > +
> > is(get_https(8443, 'http2'), 200, 'host to enabled');
> > is(get_https(8443, 'disabled', 'http2'), 421, 'host to disabled');
> > 
> > +}
> > +
> > # make sure HTTP/2 can be enabled selectively on virtual servers
> > 
> 
> Looks good, tnx.

Pushed to http://mdounin.ru/hg/nginx-tests, thanks.

> This got unnoticed since OpenSSL 1.0.1 no longer present in buildbot.
> Personally I stopped using it in manual tests as it doesn't seem to be
> correctly configured so cannot be built on Apple M1.

I usually test non-trivial SSL-related changes with all supported 
OpenSSL branches, hence it was caught.

-- 
Maxim Dounin
http://mdounin.ru/


More information about the nginx-devel mailing list