[PATCH] Configure: dump unsupported repository error and exit

Roman Arutyunyan arut at nginx.com
Tue Jun 20 13:14:03 UTC 2023


Hi,

On Tue, May 23, 2023 at 08:29:03PM +0400, Sergey Kandaurov wrote:
> 
> > On 23 May 2023, at 19:48, Roman Arutyunyan <arut at nginx.com> wrote:
> > 
> > # HG changeset patch
> > # User Roman Arutyunyan <arut at nginx.com>
> > # Date 1684856745 -14400
> > #      Tue May 23 19:45:45 2023 +0400
> > # Branch quic
> > # Node ID bd25277d0ed77a90766bc2f4153538c86621cdfc
> > # Parent  a83071314a22652d4a552e72e13d18aa4c01d79e
> > Configure: dump unsupported repository error and exit.
> > 
> > diff --git a/auto/configure b/auto/configure
> > --- a/auto/configure
> > +++ b/auto/configure
> > @@ -4,6 +4,13 @@
> > # Copyright (C) Nginx, Inc.
> > 
> > 
> > +cat << END
> > +
> > +$0: this repository is no longer supported, see README
> > +
> > +END
> > +exit 1
> > +
> > LC_ALL=C
> > export LC_ALL
> > 
> 
> Something similar to what we use for invalid options might be enough.
> Also, using "error" might help emphasize this is an error:
> 
> diff --git a/auto/configure b/auto/configure
> --- a/auto/configure
> +++ b/auto/configure
> @@ -4,6 +4,9 @@
>  # Copyright (C) Nginx, Inc.
>  
>  
> +echo "$0: error: this repository is no longer supported, see README"
> +exit 1
> +
>  LC_ALL=C
>  export LC_ALL

Usually two empty lines are added as well (see auto/lib/perl/conf for example):

diff --git a/auto/configure b/auto/configure
--- a/auto/configure
+++ b/auto/configure
@@ -4,6 +4,12 @@
 # Copyright (C) Nginx, Inc.
 
 
+echo
+echo "$0: error: this repository is no longer supported, see README"
+echo
+
+exit 1
+
 LC_ALL=C
 export LC_ALL


>  
> 
> Personally, I think this makes sense, in order to help break pipelines.
> 
> -- 
> Sergey Kandaurov
> _______________________________________________
> nginx-devel mailing list
> nginx-devel at nginx.org
> https://mailman.nginx.org/mailman/listinfo/nginx-devel

--
Roman Arutyunyan


More information about the nginx-devel mailing list