[PATCH 1 of 6] Tests: unbreak ssl_stapling.t after IO::Socket::SSL refactoring

Maxim Dounin mdounin at mdounin.ru
Mon May 22 20:36:44 UTC 2023


Hello!

On Mon, May 22, 2023 at 11:52:13PM +0400, Sergey Kandaurov wrote:

> # HG changeset patch
> # User Sergey Kandaurov <pluknet at nginx.com>
> # Date 1684773873 -14400
> #      Mon May 22 20:44:33 2023 +0400
> # Node ID 231b14e2041afed10f5c2e6f62aad298854a6379
> # Parent  a797d7428fa529e843181d802dd85bc4306b89e9
> Tests: unbreak ssl_stapling.t after IO::Socket::SSL refactoring.
> 
> Previously, the test used to check the established SSL/TLS protocol version
> using Net::SSLeay on the client side.  Now it is provided on the server side
> within a server response.  Added missing bits to make this actually work.
> 
> diff --git a/ssl_stapling.t b/ssl_stapling.t
> --- a/ssl_stapling.t
> +++ b/ssl_stapling.t
> @@ -57,6 +57,8 @@ http {
>  
>      ssl_ciphers DEFAULT:ECCdraft;
>  
> +    add_header X-SSL-Protocol $ssl_protocol always;
> +
>      server {
>          listen       127.0.0.1:8443 ssl;
>          listen       127.0.0.1:8080;
> @@ -341,7 +343,7 @@ sub staple {
>  }
>  
>  sub test_tls13 {
> -	return http_get('/', start => 1, SSL => 1) =~ /TLSv1.3/;
> +	return http_get('/', SSL => 1) =~ /TLSv1.3/;
>  }
>  
>  ###############################################################################

Looks good.

-- 
Maxim Dounin
http://mdounin.ru/


More information about the nginx-devel mailing list