[PATCH 03 of 11] QUIC: prevented generating ACK frames with discarded keys

Sergey Kandaurov pluknet at nginx.com
Wed Oct 18 15:26:45 UTC 2023

# HG changeset patch
# User Sergey Kandaurov <pluknet at nginx.com>
# Date 1697633595 -14400
#      Wed Oct 18 16:53:15 2023 +0400
# Node ID 156fe168964961d3496e6fe0567b375bdb42c784
# Parent  0ff1706a4affd40d847fd39d7c3c98f459cae6f1
QUIC: prevented generating ACK frames with discarded keys.

Previously it was possible to generate ACK frames using formally discarded
protection keys, in particular, when acknowledging a client Handshake packet
used to complete the TLS handshake and to discard handshake protection keys.
As it happens late in packet processing, it could be possible to generate ACK
frames after the keys were already discarded.

ACK frames are generated from ngx_quic_ack_packet(), either using a posted
push event, which envolves ngx_quic_generate_ack() as a part of the final
packet assembling, or directly in ngx_quic_ack_packet(), such as when there
is no room to add a new ACK range or when the received packet is out of order.
The added keys availability check is used to avoid generating late ACK frames
in both cases.

diff --git a/src/event/quic/ngx_event_quic_ack.c b/src/event/quic/ngx_event_quic_ack.c
--- a/src/event/quic/ngx_event_quic_ack.c
+++ b/src/event/quic/ngx_event_quic_ack.c
@@ -907,6 +907,10 @@ ngx_quic_ack_packet(ngx_connection_t *c,
                    " nranges:%ui", pkt->pn, (int64_t) ctx->largest_range,
                    ctx->first_range, ctx->nranges);
+    if (!ngx_quic_keys_available(qc->keys, ctx->level, 1)) {
+        return NGX_OK;
+    }
     prev_pending = ctx->pending_ack;
     if (pkt->need_ack) {

More information about the nginx-devel mailing list