[PATCH 2 of 6] Overhauled some diagnostic messages missed in 1b05b9bbcebf

Roman Arutyunyan arut at nginx.com
Tue Jan 9 13:14:07 UTC 2024


Hi,

On Fri, Dec 15, 2023 at 07:37:45PM +0400, Sergey Kandaurov wrote:
> # HG changeset patch
> # User Sergey Kandaurov <pluknet at nginx.com>
> # Date 1702647536 -14400
> #      Fri Dec 15 17:38:56 2023 +0400
> # Node ID de11f5373157db6c1e22dbad2ab4014143a5e8f8
> # Parent  cb377d36446e1ce22b71848a4a138564b2e38719
> Overhauled some diagnostic messages missed in 1b05b9bbcebf.

The commit dates back to 2011 when Stream did not exist yet.
So technically saying "missed" is not quite correct.
But since Stream is copied from Mail, that's ok.

> diff --git a/src/http/modules/ngx_http_referer_module.c b/src/http/modules/ngx_http_referer_module.c
> --- a/src/http/modules/ngx_http_referer_module.c
> +++ b/src/http/modules/ngx_http_referer_module.c
> @@ -631,7 +631,7 @@ ngx_http_add_regex_referer(ngx_conf_t *c
>  #else
>  
>      ngx_conf_log_error(NGX_LOG_EMERG, cf, 0,
> -                       "the using of the regex \"%V\" requires PCRE library",
> +                       "using regex \"%V\" requires PCRE library",
>                         name);
>  
>      return NGX_ERROR;
> diff --git a/src/http/modules/ngx_http_ssi_filter_module.c b/src/http/modules/ngx_http_ssi_filter_module.c
> --- a/src/http/modules/ngx_http_ssi_filter_module.c
> +++ b/src/http/modules/ngx_http_ssi_filter_module.c
> @@ -2001,7 +2001,7 @@ ngx_http_ssi_regex_match(ngx_http_reques
>  #else
>  
>      ngx_log_error(NGX_LOG_ALERT, r->connection->log, 0,
> -                  "the using of the regex \"%V\" in SSI requires PCRE library",
> +                  "using regex \"%V\" in SSI requires PCRE library",
>                    pattern);
>      return NGX_HTTP_SSI_ERROR;
>  
> diff --git a/src/mail/ngx_mail_core_module.c b/src/mail/ngx_mail_core_module.c
> --- a/src/mail/ngx_mail_core_module.c
> +++ b/src/mail/ngx_mail_core_module.c
> @@ -441,7 +441,7 @@ ngx_mail_core_listen(ngx_conf_t *cf, ngx
>              continue;
>  #else
>              ngx_conf_log_error(NGX_LOG_EMERG, cf, 0,
> -                               "bind ipv6only is not supported "
> +                               "ipv6only is not supported "
>                                 "on this platform");
>              return NGX_CONF_ERROR;
>  #endif
> @@ -564,7 +564,7 @@ ngx_mail_core_listen(ngx_conf_t *cf, ngx
>          }
>  
>          ngx_conf_log_error(NGX_LOG_EMERG, cf, 0,
> -                           "the invalid \"%V\" parameter", &value[i]);
> +                           "invalid \"%V\" parameter", &value[i]);
>          return NGX_CONF_ERROR;
>      }
>  
> diff --git a/src/stream/ngx_stream_core_module.c b/src/stream/ngx_stream_core_module.c
> --- a/src/stream/ngx_stream_core_module.c
> +++ b/src/stream/ngx_stream_core_module.c
> @@ -1008,7 +1008,7 @@ ngx_stream_core_listen(ngx_conf_t *cf, n
>              continue;
>  #else
>              ngx_conf_log_error(NGX_LOG_EMERG, cf, 0,
> -                               "bind ipv6only is not supported "
> +                               "ipv6only is not supported "
>                                 "on this platform");
>              return NGX_CONF_ERROR;
>  #endif
> @@ -1136,7 +1136,7 @@ ngx_stream_core_listen(ngx_conf_t *cf, n
>          }
>  
>          ngx_conf_log_error(NGX_LOG_EMERG, cf, 0,
> -                           "the invalid \"%V\" parameter", &value[i]);
> +                           "invalid \"%V\" parameter", &value[i]);
>          return NGX_CONF_ERROR;
>      }
>  
> _______________________________________________
> nginx-devel mailing list
> nginx-devel at nginx.org
> https://mailman.nginx.org/mailman/listinfo/nginx-devel

Looks fine


More information about the nginx-devel mailing list