[PATCH 4 of 4] AIO operations now add timers (ticket #2162)

[J Carter]

Hello,

On Mon, 27 Nov 2023 05:50:27 +0300
Maxim Dounin <mdounin at mdounin.ru> wrote:

> # HG changeset patch
> # User Maxim Dounin <mdounin at mdounin.ru>
> # Date 1701050170 -10800
> #      Mon Nov 27 04:56:10 2023 +0300
> # Node ID 00c3e7333145ddb5ea0eeaaa66b3d9c26973c9c2
> # Parent  61d08e4cf97cc073200ec32fc6ada9a2d48ffe51
> AIO operations now add timers (ticket #2162).
> 
> Each AIO (thread IO) operation being run is now accompanied with 1-minute
> timer.  This timer prevents unexpected shutdown of the worker process while
> an AIO operation is running, and logs an alert if the operation is running
> for too long.

Shouldn't this timer's duration be set to match worker_shutdown_timeout's
duration rather than being hard coded to 60s ?

> This fixes "open socket left" alerts during worker processes shutdown
> due to pending AIO (or thread IO) operations while corresponding requests
> have no timers.  In particular, such errors were observed while reading
> cache headers (ticket #2162), and with worker_shutdown_timeout.

[...]