[PATCH] macOS: detect cache line size at runtime

Sergey Kandaurov pluknet at nginx.com
Wed Mar 27 17:53:18 UTC 2024


> On 21 Mar 2024, at 11:19, Piotr Sikora via nginx-devel <nginx-devel at nginx.org> wrote:
> 
> Hi Sergey,
> 
>> I prefer not to introduce more ad-hoc prefixes in the log summary.
>> Something like moving the "macOS" part to the end should be fine.
> 
> That's fine with me.
> 
>> style: this breaks a perfect indentation of two spaces after type;
>> further, it appears to be unsorted by type; I'd put it after u_long
> 
> Good catch, thanks!
> 
>> This makes the following slight update to the patch.
>> If you're okey with it, I will commit it then.
> 
> LGTM.
> 

Pushed the updated patch, thanks.

-- 
Sergey Kandaurov


More information about the nginx-devel mailing list