[PATCH] Core: free connections and read/write events at shutdown

[Piotr Sikora]

Hi Sergey,

> While I agree that false positives do not allow to run LeakSanitizer
> in a clean fashion, I don't think it is nginx which should be fixed.
> Rather, sanitizer analysis could be improved instead to prevent FPs.

Patches welcome?

> Meanwhile, leak sanitizer can be used with suppressions as appropriate
> to run tests cleanly.  For example, this allows to suppress memory leak
> reports for allocations made during worker process init, such as cycle
> connections and read/write events:
> 
> $ cat suppr.txt
> leak:ngx_worker_process_init
> $ LSAN_OPTIONS=suppressions=suppr.txt prove -r

Right, but that's an unnecessary step that prevents potential contributors
from using LeakSanitizer with NGINX. Also, I don't think that you're using
those tools either, likely because of those few false positives.

Best regards,
Piotr Sikora