[njs] Fixed dead store assignment in r.subrequest().

noreply at nginx.com noreply at nginx.com
Mon Oct 14 23:52:02 UTC 2024


details:   https://github.com/nginx/njs/commit/8759db7458f54d1d2c4d7657a68ca69c51a5c774
branches:  master
commit:    8759db7458f54d1d2c4d7657a68ca69c51a5c774
user:      Dmitry Volyntsev <xeioex at nginx.com>
date:      Fri, 11 Oct 2024 18:41:27 -0700
description:
Fixed dead store assignment in r.subrequest().

Found by Clang static analyzer.

---
 nginx/ngx_http_js_module.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/nginx/ngx_http_js_module.c b/nginx/ngx_http_js_module.c
index c34fccbd..6f026293 100644
--- a/nginx/ngx_http_js_module.c
+++ b/nginx/ngx_http_js_module.c
@@ -3474,7 +3474,6 @@ ngx_http_js_ext_subrequest(njs_vm_t *vm, njs_value_t *args, njs_uint_t nargs,
         return NJS_ERROR;
     }
 
-    promise = 0;
     flags = NGX_HTTP_SUBREQUEST_BACKGROUND;
 
     njs_value_undefined_set(retval);
@@ -5859,7 +5858,6 @@ ngx_http_qjs_ext_subrequest(JSContext *cx, JSValueConst this_val,
                                      "exclusive");
     }
 
-    promise = 0;
     retval = JS_UNDEFINED;
     flags = NGX_HTTP_SUBREQUEST_BACKGROUND;
 


More information about the nginx-devel mailing list