https + large-file sending, sometimes fails

[Gábor Farkas]

Igor Sysoev wrote:
> On Thu, Dec 20, 2007 at 01:40:09PM +0300, Igor Sysoev wrote:
> 
>> On Thu, Dec 20, 2007 at 01:30:50PM +0300, Igor Sysoev wrote:
>>
>>> On Thu, Dec 20, 2007 at 01:16:19PM +0300, Igor Sysoev wrote:
>>>
>>>> On Thu, Dec 20, 2007 at 10:55:16AM +0100, G?bor Farkas wrote:
>>>>
>>>>> also, something i say by the testing: if you start to do a lot of 
>>>>> concurrent requests, and start to kill the clients (which are fetching 
>>>>> the file), then also other requests start to die more frequently then 
>>>>> normally.
>>>> Thank you, I have just reproduce the case.
>>> The attached patch should fix the bug.
>> The complete patch.
> 
> The new commited patch.
> 
> 1st, it fixes the cause of bug - SSL_shutdown() handling.
> SSL_shutdown() man states incorrectly that SSL_shutdown() will return -1
> on error. Actually SSL_shutdown() never returns -1.
> 
> 2nd, it clears and logs possible previously unhandled SSL errors so
> they have not affect on a new operation.


hi,

we tested your patch (not this one, but the previous one (the "
The complete patch." one), and it seems to fix the problem.

(we were fetching an 50MB file using 20 concurrent connections, and in 
parallel there was one more connection, that was starting and killing 
it's download. do you have any idea how to test it even better maybe?)

regarding this one... when will there be a new version of nginx, which 
contains this patch? :-)

or, alternatively, is there a public git/mercurial/svn/whatever repo for 
nginx?

also, thanks a lot for the bugfix,

gabor