SSL downloads broken in 0.5.35

[Igor Sysoev]

On Fri, Jan 11, 2008 at 07:06:55PM +1100, Dave Cheney wrote:

> 	Sadly this has not fixed the problem
> 
> 2008/01/11 19:05:10 [crit] 16702#0: *123 SSL_write() failed (SSL:  
> error:1409F07F:SSL routines:SSL3_WRITE_PENDING:bad write retry) while  
> sending to client, client: 220.253.63.155, server:  
> staging.redbbuble.com, request: "GET /admin/purchase_orders/ 
> download_file/121447 HTTP/1.1", upstream: 
> "http://127.0.0.1:8013/admin/purchase_orders/download_file/121447 ", host: 
> "staging.redbubble.com"

The additional patch (should be used with patch-0.5.35.1.txt).

> Cheers
> 
> Dave
> 
> On 11/01/2008, at 6:07 PM, Igor Sysoev wrote:
> 
> >On Fri, Jan 11, 2008 at 02:07:38PM +1100, Dave Cheney wrote:
> >
> >>	We had been using 0.5.34 + the SSL patch placed on this list a month
> >>ago which has solved our SSL download issues.
> >>
> >>	After upgrading to 0.5.35 the error has again returned.
> >>
> >>	2008/01/11 14:03:51 [crit] 10251#0: *1 SSL_write() failed (SSL:
> >>	error: 1409F07F:SSL routines:SSL3_WRITE_PENDING:bad write retry)  
> >>while
> >>sending to client, client: 150.101.157.6, server:
> >>staging.redbbuble.com, request: "GET /admin/purchase_orders/
> >>download_file/121447 HTTP/1.1", upstream:
> >>"http://127.0.0.1:8013/admin/purchase_orders/download_file/121447  
> >>", host:
> >>"staging.redbubble.com"
> >>
> >>	No SSL download will transfer more that 40-60kb before closing the
> >>connection abruptly.
> >>
> >>	Please let me know if I can be of any assistance to debug this issue
> >>further.
> >
> >Strange. Could you test the attached patch against 0.5.35 ?
> >
> >
> >-- 
> >Igor Sysoev
> >http://sysoev.ru/en/
> ><patch-0.5.35.1.txt>
> 
> 

-- 
Igor Sysoev
http://sysoev.ru/en/
-------------- next part --------------
Index: src/event/ngx_event_openssl.c
===================================================================
--- src/event/ngx_event_openssl.c	(revision 1174)
+++ src/event/ngx_event_openssl.c	(working copy)
@@ -885,10 +885,10 @@
     int        n, sslerr;
     ngx_err_t  err;
 
+    ngx_log_debug1(NGX_LOG_DEBUG_EVENT, c->log, 0, "SSL to write: %d", size);
+
     ngx_ssl_clear_error(c->log);
 
-    ngx_log_debug1(NGX_LOG_DEBUG_EVENT, c->log, 0, "SSL to write: %d", size);
-
     n = SSL_write(c->ssl->connection, data, size);
 
     ngx_log_debug1(NGX_LOG_DEBUG_EVENT, c->log, 0, "SSL_write: %d", n);