[BUG] incorrect macro ngx_log_alloc_log

Igor Sysoev is at rambler-co.ru
Tue Mar 18 23:03:27 MSK 2008


On Tue, Mar 18, 2008 at 08:27:48PM +0100, Manlio Perillo wrote:

> Igor Sysoev ha scritto:
> >On Mon, Mar 17, 2008 at 11:25:53PM +0100, Manlio Perillo wrote:
> >
> >>The macro in core/ngx_log.h is not correct:
> >>
> >>#define ngx_log_alloc_log(pool, log)  ngx_palloc(pool, log, 
> >>sizeof(ngx_log_t))
> >>
> >>
> >>ngx_palloc only requires two arguments.
> >>
> >>
> >>This function is never used, but I was trying to use it in mod_wsgi!
> >
> >Please, do not use it, I will remove this ancient artifact.
> >
> 
> Ok, thanks.

I will also remove ngx_log_copy_log(), because it the same as:

    *newlog = *oldlog;

> By the way, I use it to make a copy of ngx_cycle->log, since I need to 
> modify the log->connection attribute.


-- 
Igor Sysoev
http://sysoev.ru/en/





More information about the nginx mailing list