find bug in dns resovle

Igor Sysoev is at rambler-co.ru
Wed Nov 19 00:50:24 MSK 2008


On Tue, Nov 18, 2008 at 10:43:32PM +0100, Robert Gabriel wrote:

> Igor Sysoev wrote:
> > On Mon, Nov 17, 2008 at 10:20:34AM +0800, nginx at aqcx.com wrote:
> > 
> >>    in function ngx_resolver_copy ,n = (n & 0x3f << 8) + *p;
> >>   should be n = ((n & 0x3f) << 8) + *p;otherwis ,& oprator will not work correctlly.
> > 
> > Thank you very much.
> > I had missed it as it becomes apparent on big (>256 bytes) DNS 
> > responses.
> > What is your full name to include in CHANGES log ?
> 
> Isnt the same idea of
> n = (n & 0x3f << 8) + *src;
> 
> should this be:
> 
> n = ((n & 0x3f << 8) + *src);
> 
> Sorry I might be wrong... but who knows :P

This is the same.


-- 
Igor Sysoev
http://sysoev.ru/en/





More information about the nginx mailing list