nginx-0.8.31
Piotr Sikora
piotr.sikora at frickle.com
Tue Dec 29 06:13:02 MSK 2009
Hello Maxim,
>> *) Bugfix: nginx closed a connection if a cached response had an
>> empty
>> body.
>> Thanks to Piotr Sikora.
>
> I belive setting r->header_only here is wrong aproach. At least
> it breaks addition filter module for such responses.
>
> Also you probably want to consider doubled last chunk for stale
> responses as fixed here:
>
> http://nginx.org/pipermail/nginx/2009-October/015789.html
You are right, this will break addition filter module.
Your patch works as expected, I wonder why it wasn't applied in the first
place?
Anyway, I modified your patch a little to avoid unnessesary call to
ngx_pcalloc. Hopefully Igor will include this in nginx-0.8.32 ;)
Best regards,
Piotr Sikora < piotr.sikora at frickle.com >
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cached_0_byte_files_fix_v2.patch
Type: application/octet-stream
Size: 1757 bytes
Desc: not available
URL: <http://nginx.org/pipermail/nginx/attachments/20091229/1765462e/attachment.obj>
More information about the nginx
mailing list