Bugs in nginx ./configure procedure: part 2

J. Antas antas at e-healthexpert.org
Tue Mar 24 18:12:35 MSK 2009


1. Runing the nginx ./configure procedure that comes with the 
<http://sysoev.ru/nginx/nginx-0.7.44.tar.gz> package creates a
double line in the install section of objs/Makefile file:

test -d '$(DESTDIR)/etc/nginx'


2. Also the line:
test ! -f '$(DESTDIR)/usr/sbin/nginx' || mv '$(DESTDIR)/usr/sbin/nginx' 
'$(DESTDIR)/usr/sbin/nginx.old'

Would be better interpreted by automated install routines, like 
checkinstall, if defined as:
  test -f '$(DESTDIR)/usr/sbin/nginx' && mv '$(DESTDIR)/usr/sbin/nginx' 
'$(DESTDIR)/usr/sbin/nginx.old'


M.

--

--- nginx-0.7.44/objs/Makefile	2009-03-24 14:48:04.000000000 +0000
+++ nginx-0.7.44/objs/Makefile.new	2009-03-24 15:09:29.000000000 +0000
@@ -1,6 +1,6 @@

  CC =	gcc
-CFLAGS =  -O -pipe  -O -W -Wall -Wpointer-arith -Wno-unused-parameter 
-Wno-unused-function -Wunused-variable -Wunused-value -Werror -g -O2
+CFLAGS = -pipe -W -Wall -Wpointer-arith -Wno-unused-parameter 
-Wno-unused-function -Wunused-variable -Wunused-value -Werror -g -O2
  CPP =	gcc -E
  LINK =	$(CC)

@@ -1003,10 +1003,8 @@


  install:	objs/nginx 		
-	test -d '$(DESTDIR)/etc/nginx' || mkdir -p '$(DESTDIR)/etc/nginx'
-
  	test -d '$(DESTDIR)/usr/sbin' 		|| mkdir -p '$(DESTDIR)/usr/sbin'
-	test ! -f '$(DESTDIR)/usr/sbin/nginx' 		|| mv 
'$(DESTDIR)/usr/sbin/nginx' 			'$(DESTDIR)/usr/sbin/nginx.old'
+	test -f '$(DESTDIR)/usr/sbin/nginx' 		&& mv 
'$(DESTDIR)/usr/sbin/nginx' 			'$(DESTDIR)/usr/sbin/nginx.old'
  	cp objs/nginx '$(DESTDIR)/usr/sbin/nginx'

  	test -d '$(DESTDIR)/etc/nginx' 		|| mkdir -p '$(DESTDIR)/etc/nginx'





More information about the nginx mailing list