Websocket tunnel broken with existing SSL session

Maxim Dounin mdounin at mdounin.ru
Fri Jan 17 17:01:38 UTC 2014


Hello!

On Fri, Jan 17, 2014 at 12:15:25PM +0000, Eiríkur Nilsson wrote:

> Hey Maxim
> 
> On Thu, Jan 16, 2014 at 10:01 PM, Maxim Dounin <mdounin at mdounin.ru> wrote:
> >
> >
> > Please try the following patch:
> 
> 
> Wow, everything seems to work correctly with this patch, session reuse and
> everything. I thought this patch would close the new connection, causing a
> fresh reconnect, but I don't see that happening in the capture. Is nginx
> holding on to - and trying to use - a handle to the old connection, which
> needs cleanup?

The problem is that read event was removed after ssl handshake, 
and never added back - so new data on client connection were not 
reported by the kernel.  The ngx_handle_read_event() call ensures 
that an appropriate event is added again.

> Do you think this patch might get applied into the mainline?

Yes, after some more testing and review.

-- 
Maxim Dounin
http://nginx.org/



More information about the nginx mailing list