[PROPOSAL PATCH] use a return code for ngx_http_terminate_request()

Maxim Dounin mdounin at mdounin.ru
Fri Jun 27 19:38:29 UTC 2014


On Fri, Jun 27, 2014 at 09:07:27AM -0400, crespin wrote:

> Hello,
> Reading ngx_http_request.c source code, I notice some call to
> ngx_http_terminate_request() is called sometimes with 0 instead of a return
> code.
> 0 is a correct valid for a return code ... it's NGX_OK.
> Is the patch valid ?

The ngx_http_terminate_request() function uses "rc" only when it's 
positive, and "0" doesn't really mean anything except "we don't 
have error code".

Maxim Dounin

More information about the nginx mailing list