DTLS patches

[shankerwangmiao]

Vladimir Homutov Wrote:
-------------------------------------------------------
> On Wed, Feb 21, 2018 at 12:18:27PM +0800, Wang Shanker wrote:
> > Hi, Vladimir
> >
> > `ngx_stream_ssl_init_connection` trys to set tcp_nodelay on the
> given connection.
> > The following patch adds a test for the type of connection before
> set.
> >
> > Cheers,
> >
> > Miao Wang
> >
> > diff --git a/src/stream/ngx_stream_ssl_module.c
> b/src/stream/ngx_stream_ssl_module.c
> > index f85bbb6..36f7fdd 100644
> > --- a/src/stream/ngx_stream_ssl_module.c
> > +++ b/src/stream/ngx_stream_ssl_module.c
> > @@ -369,7 +369,7 @@ ngx_stream_ssl_init_connection(ngx_ssl_t *ssl,
> ngx_connection_t *c)
> >
> >     cscf = ngx_stream_get_module_srv_conf(s,
> ngx_stream_core_module);
> >
> > -    if (cscf->tcp_nodelay && ngx_tcp_nodelay(c) != NGX_OK) {
> > +    if (cscf->tcp_nodelay && c->type == SOCK_STREAM &&
> ngx_tcp_nodelay(c) != NGX_OK) {
> >         return NGX_ERROR;
> >     }
> >
> >
> 
> Hi, Miao
> 
> The change is indeed correct, it is required since
> http://hg.nginx.org/nginx/rev/29c6d66b83ba
> 
> Have you tried patches in work?
> _______________________________________________
> nginx mailing list
> nginx at nginx.org
> http://mailman.nginx.org/mailman/listinfo/nginx

I have tested this patch in my environment. Before the patch is applied,
`tcp_nodelay off` needs to be placed in every `server` clause with DTLS
enabled to work the problem around.

Posted at Nginx Forum: https://forum.nginx.org/read.php?2,274289,278704#msg-278704