CID 308517 (#1 of 1): Missing unlock (LOCK)

[Valentin V. Bartenev]

On Wednesday, 12 June 2019 01:59:37 MSK Ranier Vf wrote:
> description: CID 308517 (#1 of 1): Missing unlock (LOCK)
> unit: nxt_unit.c
> 
> According Coverity Scan, missing_unlock: Returning without unlocking
> lib->mutex.

We use Coverity on a daily basis.  While sometimes it catches
something interesting, but most of the time it has lots of false
positives.

> 
> --- c:\web\nginx\unit\a\src\nxt_unit.c    Mon Jun 10 12:47:35 2019
> +++ nxt_unit.c    Tue Jun 11 19:50:59 2019
> @@ -3140,6 +3140,7 @@
>      }
> 
>      nxt_unit_remove_process(ctx, process);
> +    pthread_mutex_unlock(&lib->mutex);
>  }
> 

The nxt_unit_remove_process() function always unlocks this mutex.

  wbr, Valentin V. Bartenev