Unused struct field bucket_mask (was: Re: [PATCH 04/11] Port: removed useless msg->cancelled == 0 checks.)

[Andrew Clayton]

On Sat, 18 Jun 2022 01:49:56 +0200
Alejandro Colomar <alx.manpages at gmail.com> wrote:

> Hi Andrew,

Hi Alex,

[...]

Thanks for the detailed explanations, I'll need some time to digest it
all!
 
> > I just don't know how to trigger that code, i.e what unit config would
> > make use of this?  
> 
> Heh, good look triggering that! :p
> 
> I guess you could add an abort there, and run the whole pytest (maybe 
> even with some modules, if the base doesn't trigger it), to see if some 
> of that triggers it?

Yeah, I had tried that, but good call on trying with modules enabled,
unfortunately it never gets into that if block. I think I managed to test
with all modules except ruby, the tests blow up there.

> >> I wonder how the world did this without grepc(1) :p  
> > 
> > I have ctags set up for unit, useful.  
> 
> I read about it, but didn't feel easy to use.  I just wanted to grep for 
> stuff, without having to set up anything.  Also, it works integrated 
> with the editor, which is something I try to avoid (I don't like IDEs, 
> and wouldn't want to transform vim(1) into one).  The UNIX way (one-shot 
> run, dump stuff into stdout) seems better to my taste.

Heh. I'm all for the UNIX philosophy :) it's really all I've used for
the past 25+ years!

So I do use it with vim, but it is quite un-intrusive, you wouldn't
even know it was there! Simply doing Ctrl-] will take you to the type
definition of what's currently under the cursor and Ctrl-t will take you
back. There's some other things you can do of course, but that's
basically it.

Other than setting a theme (colo iceberg), a ruler down the 80 column
margin (set ruler, set cc=80) and having the current line highlighted
(set cursorline) and various autocmd's for C and git commits my vim set
up is pretty bog standard.

Cheers,
Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.nginx.org/pipermail/unit/attachments/20220618/0ce5d099/attachment.bin>