[PATCH 09/11] Router: removed unused structure member proxy_buffers.

[Alejandro Colomar]

Hi Andrew,

On 6/16/22 20:17, Andrew Clayton wrote:
> On Thu, 16 Jun 2022 18:01:15 +0200
> Alejandro Colomar <alx.manpages at gmail.com> wrote:
> 
> 
>> BTW, I didn't know about pahole(1).  It would be nice to show the
>> command invocation before the command output, to see how it works :)
> 
> Actually I notice with TLS enabled we are back to 4 cachelines
> 
> $ pahole -C nxt_socket_conf_t build/unitd

[...]

> 
> However if we move count to after the nxt_msec_t's that brings us back
> down to 3 again even with TLS enabled.
> 

[...]

> 
> So unless there is a good reason that count is the first member then
> it's probably worth doing.

It would be good.  But since this code uses a lot of aliasing, I'd like 
to be completely sure that we can do that.  If you prove that no code 
relies on the order of the structure, it makes sense to me to reduce 
cache lines.

Cheers,

Alex

-- 
Alejandro Colomar
<http://www.alejandro-colomar.es/>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.nginx.org/pipermail/unit/attachments/20220617/191b8bb8/attachment.bin>