[PATCH 10/18] Removed nxt_always_inline from nxt_perl_psgi_cb_request_done().

Alejandro Colomar alx.manpages at gmail.com
Thu Jun 2 18:05:04 UTC 2022


We shouldn't be forcing the inline of a function that is used most
of the time in nxt_slow_path (error cases).

See the usage:

$ grep -rh nxt_perl_psgi_cb_request_done src/
nxt_perl_psgi_cb_request_done(nxt_perl_psgi_ctx_t *pctx, int status)
    nxt_perl_psgi_cb_request_done(CvXSUBANY(cv).any_ptr, NXT_UNIT_OK);
        nxt_perl_psgi_cb_request_done(CvXSUBANY(cv).any_ptr, NXT_UNIT_ERROR);
        nxt_perl_psgi_cb_request_done(CvXSUBANY(cv).any_ptr, NXT_UNIT_ERROR);
        nxt_perl_psgi_cb_request_done(CvXSUBANY(cv).any_ptr, NXT_UNIT_ERROR);
    nxt_perl_psgi_cb_request_done(CvXSUBANY(cv).any_ptr, NXT_UNIT_OK);
        nxt_perl_psgi_cb_request_done(pctx, NXT_UNIT_ERROR);
---
 src/perl/nxt_perl_psgi.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/perl/nxt_perl_psgi.c b/src/perl/nxt_perl_psgi.c
index 96a6519..6700d39 100644
--- a/src/perl/nxt_perl_psgi.c
+++ b/src/perl/nxt_perl_psgi.c
@@ -229,7 +229,6 @@ XS(XS_NGINX__Unit__Sandbox_write)
 }
 
 
-nxt_always_inline
 static inline void
 nxt_perl_psgi_cb_request_done(nxt_perl_psgi_ctx_t *pctx, int status)
 {
-- 
2.36.1



More information about the unit mailing list