[PATCH 02/11] Constified numerous function parameters.

Andrew Clayton andrew at digital-domain.net
Thu Jun 16 17:09:27 UTC 2022


On Thu, 16 Jun 2022 17:45:01 +0200
Alejandro Colomar <alx.manpages at gmail.com> wrote:

> Hi Andrew,

Hi Alex,

>  From my side, as long as it compiles, and doesn't require any casts, 
> `const` is always welcome.

Heh, yeah it compiles and no casts were introduced :)

> I'm actually surprised that only 41 lines were changed with this.

There were some other places that could be made const but they would
require more code changes...
 
> Reviewed-by: Alejandro Colomar <alx.manpages at gmail.com>

Thanks!
 
> (We don't use those in the commit logs, but just to state that I 
> reviewed it).

Though I think it would be beneficial if we did.
 
Cheers,
Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.nginx.org/pipermail/unit/attachments/20220616/7345fa55/attachment.bin>


More information about the unit mailing list