[nginx] Fixed build with signed socklen_t and unix sockets.

Maxim Dounin mdounin at mdounin.ru
Mon Aug 5 07:42:15 UTC 2013


details:   http://hg.nginx.org/nginx/rev/1fe5f7fb6ced
branches:  
changeset: 5313:1fe5f7fb6ced
user:      Maxim Dounin <mdounin at mdounin.ru>
date:      Mon Aug 05 11:40:33 2013 +0400
description:
Fixed build with signed socklen_t and unix sockets.

This seems to be the case at least under Cygwin, where build was broken
by 05ba5bce31e0 (1.5.3).

Reported by Kevin Worthington,
http://mailman.nginx.org/pipermail/nginx/2013-August/040028.html.

diffstat:

 src/core/ngx_inet.c |  2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diffs (12 lines):

diff --git a/src/core/ngx_inet.c b/src/core/ngx_inet.c
--- a/src/core/ngx_inet.c
+++ b/src/core/ngx_inet.c
@@ -233,7 +233,7 @@ ngx_sock_ntop(struct sockaddr *sa, sockl
 
         /* on Linux sockaddr might not include sun_path at all */
 
-        if (socklen <= offsetof(struct sockaddr_un, sun_path)) {
+        if (socklen <= (socklen_t) offsetof(struct sockaddr_un, sun_path)) {
             p = ngx_snprintf(text, len, "unix:%Z");
 
         } else {



More information about the nginx-devel mailing list