[PATCH] Configure: added new option --with-pcre-conf-opt=OPTIONS.

[Maxim Dounin]

Hello!

On Tue, Dec 10, 2013 at 09:14:15AM -0800, Yichun Zhang (agentzh) wrote:

> Hello!
> 
> Right now, when PCRE is compiled from source via --with-pcre, there is
> no way to add custom PCRE configure options for the PCRE build, like
> --enable-utf8. The following patch adds the new option
> --with-pcre-conf-opt=OPTIONS for this purpose.
> 
> Comments welcome as always! :)
> 
> Thanks!
> -agentzh
> 
> # HG changeset patch
> # User Yichun Zhang <agentzh at gmail.com>
> # Date 1386694955 28800
> # Node ID 9ba6b149669f1f02eeb4cdc0ebd364a949b5c469
> # Parent  30e806b8636af5fd3f03ec17df24801f390f7511
> Configure: added new option --with-pcre-conf-opt=OPTIONS.
> 
> diff -r 30e806b8636a -r 9ba6b149669f auto/options
> --- a/auto/options Mon Dec 09 10:16:44 2013 +0400
> +++ b/auto/options Tue Dec 10 09:02:35 2013 -0800
> @@ -286,6 +286,7 @@
>          --with-pcre)                     USE_PCRE=YES               ;;
>          --with-pcre=*)                   PCRE="$value"              ;;
>          --with-pcre-opt=*)               PCRE_OPT="$value"          ;;
> +        --with-pcre-conf-opt=*)          PCRE_CONF_OPT="$value"     ;;
>          --with-pcre-jit)                 PCRE_JIT=YES               ;;
> 
>          --with-openssl=*)                OPENSSL="$value"           ;;
> @@ -441,6 +442,7 @@
>    --with-pcre                        force PCRE library usage
>    --with-pcre=DIR                    set path to PCRE library sources
>    --with-pcre-opt=OPTIONS            set additional build options for PCRE
> +  --with-pcre-conf-opt=OPTIONS       set additional configure options for PCRE
>    --with-pcre-jit                    build PCRE with JIT compilation support

I don't like the idea of having both --with-pcre-opt= and 
--with-pcre-conf-opt= at the same time.  Especially if we keep in 
mind that "--with-...-opt=" means either CFLAGS or configure 
options depending on the library.

(Just in case, an equivalent to passing --enable-utf to PCRE 
configure would be to use --with-pcre-opt="-DSUPPORT_UTF".)

-- 
Maxim Dounin
http://nginx.org/