[PATCH] DragonFlyBSD KEEPALIVE_TUNABLE

[Tom van der Woerdt]

Hi,

Wouldn't a better place for this patch be the configure script instead of hardcoding the values?

Tom


> On 25 jul. 2013, at 03:32, Sepherosa Ziehau <sepherosa at gmail.com> wrote:
> 
>> On Wed, Jul 24, 2013 at 10:32 PM, Maxim Konovalov <maxim at nginx.com> wrote:
>> Hi,
>> 
>>> On 7/24/13 5:42 PM, Sepherosa Ziehau wrote:
>>> Hi,
>>> 
>>> On DragonFlyBSD, TCP_KEEPIDLE and TCP_KEEPINTVL are in milliseconds
>>> instead of seconds.  Following patch fixes this:
>>> http://leaf.dragonflybsd.org/~sephe/ngx_keepalive.diff
>> Thanks for the patch!
>> 
>> Just curious: are there any reasons why these timers have a
>> millisecond resolution and not compatible with other BSD's?
> 
> When I added TCP_KEEP* sockopts to DragonFlyBSD, I checked the unit of
> TCP_KEEP* on various systems that had implemented them (FreeBSD did
> not have that option at that time; not sure about NetBSD).  They are
> using different unit, some use half-second (e.g. OpenVMS), some use 1
> second (e.g. Linux); and there is no standard specifies which unit
> should be used.  Another reason is that I want to keep the sockopts'
> unit consistent w/ the sysctls' unit.  Well, and I actually used
> TCP_KEEP* sockopts in my own project at that time, which requires
> higher resolution TCP_KEEP* ;)
> 
> Best Regards,
> sephe
> 
> -- 
> Tomorrow Will Never Die
> 
> _______________________________________________
> nginx-devel mailing list
> nginx-devel at nginx.org
> http://mailman.nginx.org/mailman/listinfo/nginx-devel