[nginx] SPDY: fixed reversed priority order in window waiting qu...

[Valentin Bartenev]

details:   http://hg.nginx.org/nginx/rev/2bc609a4b516
branches:  
changeset: 5576:2bc609a4b516
user:      Valentin Bartenev <vbart at nginx.com>
date:      Wed Feb 12 21:02:29 2014 +0400
description:
SPDY: fixed reversed priority order in window waiting queue.

diffstat:

 src/http/ngx_http_spdy.h               |  3 +++
 src/http/ngx_http_spdy_filter_module.c |  5 ++++-
 2 files changed, 7 insertions(+), 1 deletions(-)

diffs (28 lines):

diff -r d15822784cf9 -r 2bc609a4b516 src/http/ngx_http_spdy.h
--- a/src/http/ngx_http_spdy.h	Tue Feb 11 21:54:42 2014 -0800
+++ b/src/http/ngx_http_spdy.h	Wed Feb 12 21:02:29 2014 +0400
@@ -174,6 +174,9 @@ ngx_http_spdy_queue_frame(ngx_http_spdy_
 
     for (out = &sc->last_out; *out; out = &(*out)->next)
     {
+        /*
+         * NB: higher values represent lower priorities.
+         */
         if (frame->priority >= (*out)->priority) {
             break;
         }
diff -r d15822784cf9 -r 2bc609a4b516 src/http/ngx_http_spdy_filter_module.c
--- a/src/http/ngx_http_spdy_filter_module.c	Tue Feb 11 21:54:42 2014 -0800
+++ b/src/http/ngx_http_spdy_filter_module.c	Wed Feb 12 21:02:29 2014 +0400
@@ -967,7 +967,10 @@ ngx_http_spdy_waiting_queue(ngx_http_spd
     {
         s = ngx_queue_data(q, ngx_http_spdy_stream_t, queue);
 
-        if (s->priority >= stream->priority) {
+        /*
+         * NB: higher values represent lower priorities.
+         */
+        if (stream->priority >= s->priority) {
             break;
         }
     }