[PATCH] SPDY: set $scheme from scheme request header

[Ragnar Rova]

Sorry, my mistake, I was introducing a vulnerability by this.

So, without the patch, how do I setup the redirect from http to https urls
when a http url was visited over spdy/tls?

I have

server {
       listen 1.2.3.4:80;

       location ~ ^/(path1|path2)$ {
                rewrite  ^/(.*)$  https://mysite.com/$1  permanent;
                break;
       }

       location / {
                add_header        Alternate-Protocol  443:npn-spdy/2;
       }
 }

server {
       listen 1.2.3.4:443 ssl spdy;

       location ~ ^/(path1|path2)$ {
                rewrite  ^/(.*)$  https://mysite.com/$1  permanent;
                break;
       }

      location / {
               # this location is reachable using a http:// url when using
spdy. If so, we want a redirect to the https:// url. How?
       }
}


On Wed, Jan 29, 2014 at 11:36 PM, Valentin V. Bartenev <vbart at nginx.com>wrote:

> On Wednesday 29 January 2014 23:06:40 Ragnar Rova wrote:
> > # HG changeset patch
> > # User Ragnar Rova <ragnar.rova at gmail.com>
> > # Date 1391033075 -3600
> > #      Wed Jan 29 23:04:35 2014 +0100
> > # Node ID 6654eae26c8b2a718e5ad116650faf37f7be7aa9
> > # Parent  01e2a5bcdd8f65f4f7bcb23ac35911da08e5945f
> > SPDY: set $scheme from scheme request header.
> >
> > $scheme variable is always "https" when using spdy, existing code
> > just sets scheme to https based on if we are on a ssl connection.
>
> Yes, and it is intentionally.
>
> > In spdy, there is a scheme header which should be used.
>
> There is nothing special about spdy, the scheme also can be passed using
> request line in plain http or https, and nginx ignores it too.
>
> > Chrome uses http:// urls when establishing connections to sites using
> the
> > Alternate-Protocol header. If you want some locations to be visible
> > to the user as https, you can use $scheme in a http to https
> > redirect rule.
>
> You can use it without this change.  But the patch converts $scheme from
> a configuration restricted variable into an untrusted one (which can
> contain
> arbitrary value sent by client).
>
>   wbr, Valentin V. Bartenev
>
> _______________________________________________
> nginx-devel mailing list
> nginx-devel at nginx.org
> http://mailman.nginx.org/mailman/listinfo/nginx-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.nginx.org/pipermail/nginx-devel/attachments/20140130/e1eafa64/attachment.html>